Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: add consistent_read in example base on client_read API to provide consistent read from statemacine #218

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Refactor: add consistent_read in example base on client_read API to provide consistent read from statemacine #218

merged 7 commits into from
Mar 2, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Feb 28, 2022 •
edited by drmingdrmer
Loading

  1. Refactor: add consistent_read in example base on is_leader API to provide consistent read from statemacine"
  2. rename API client_read to is_leader.
  3. update gitignore file.

This change is Reviewable

@lichuang
Fix: in t60_large_heartbeat test, make wait duration to 600ms instead…
fbebae9 
… of 500ms, cause in this test set max_payload_entries to 2, make append_entries more slowly, and may fail in some time
drmingdrmer
drmingdrmer approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:DDD

@lichuang lichuang removed the request for review from ariesdevil March 1, 2022 13:30
drmingdrmer
drmingdrmer approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:DD

drmingdrmer
drmingdrmer approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again:D

@lichuang lichuang requested a review from ariesdevil March 2, 2022 03:39
ariesdevil
ariesdevil approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit c11b021 into datafuselabs:main Mar 2, 2022
@lichuang lichuang deleted the add_consistent_read_from_sm branch March 2, 2022 06:39
@lichuang lichuang mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lichuang @drmingdrmer @ariesdevil