Fix: workaround cargo leaking SSL_CERT_FILE issue #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
30-ci-doc
branch
2 times, most recently
from
aa0f4f4
to
627248f
Compare
- Test examples on debug level. Initialize logging for example - Add timeout control to client in the example. Do not let it block for ever.
drmingdrmer
force-pushed
the
30-ci-doc
branch
from
929bfbc
to
aee4150
Compare
drmingdrmer
changed the title
drmingdrmer
force-pushed
the
30-ci-doc
branch
3 times, most recently
from
5991a05
to
dec6de9
Compare
On Linux: command `cargo run` pollutes environment variables: It leaks `SSL_CERT_FILE` and `SSL_CERT_DIR` to the testing sub progress it runs. Which cause `reqwest` spending ~50 ms loading the certificates for every RPC. We just extend the RPC timeout to work around. - Fix: datafuselabs#550
drmingdrmer
force-pushed
the
30-ci-doc
branch
from
dec6de9
to
0e7ab5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fix: workaround cargo leaking SSL_CERT_FILE issue
On Linux: command
cargo runpollutes environment variables: It leaksSSL_CERT_FILEandSSL_CERT_DIRto the testing sub progress it runs.Which cause
reqwestspending ~50 ms loading the certificates for everyRPC.
We just extend the RPC timeout to work around.
Refactor: add logging and timeout to example
Test examples on debug level. Initialize logging for example
Add timeout control to client in the example. Do not let it block for
ever.
CI: quit with error if fail to build doc in Makefile and CI
This change is