Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @datagouv/select-a11y #402

Merged

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Apr 23, 2024

This PR uses the newly published @datagouv/select-a11y (datagouv/data.gouv.fr#1317 for details).

Fixes datagouv/data.gouv.fr#1270.

Note

@datagouv/select-a11y is moved from devDependencies to dependencies to help us distinguish dependencies used in udata-front, following #354. This is an ongoing process and all our dependencies aren't moved yet.
They aren't really needed in the production environment because the js is bundled before.

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nicolaskempf57 nicolaskempf57 merged commit 96c8963 into datagouv:master Apr 30, 2024
7 checks passed
@nicolaskempf57 nicolaskempf57 deleted the feat/use-datagouv-select-a11y branch April 30, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants