Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts | Sunburst: UI/UX improvements #2098

Closed
6 tasks done
LaykDimon opened this issue Jun 29, 2023 · 4 comments
Closed
6 tasks done

Charts | Sunburst: UI/UX improvements #2098

LaykDimon opened this issue Jun 29, 2023 · 4 comments
Assignees
@Aleksashka11
Labels
enhancement New feature or request NX NIBR-related

Comments

@LaykDimon
Copy link
Collaborator

LaykDimon commented Jun 29, 2023 •
edited by ahadzhanian

  • If color coding - render sunburst sectors color-coded
  • If the text doesn't fit - remove it
  • Add tooltips
  • Check that the molecule renderer will work properly on the sunburst plot
  • Verify that the hierarchy column order is persisted properly if we reopen the "hierarchy" dialog
  • Fix wrong behavior - second-level classes are not aggregated (more - https://community.datagrok.ai/t/sunburst-plot/746/5)
@LaykDimon LaykDimon added the NX NIBR-related label Jun 29, 2023
@LaykDimon LaykDimon self-assigned this Jun 29, 2023
@LaykDimon LaykDimon added the enhancement New feature or request label Jun 29, 2023
Aleksashka11 added a commit that referenced this issue Jul 24, 2023
@Aleksashka11
#2098: Charts | Sunburst: UI/UX improvements (add tooltips, remove an…
0389ed2 
…imation)
Aleksashka11 added a commit that referenced this issue Jul 24, 2023
@Aleksashka11
#2098: Charts | Sunburst: UI/UX improvements (sync with column color …
0dd1cf2 
…coding)
Aleksashka11 added a commit that referenced this issue Jul 26, 2023
@Aleksashka11
#2098: Sunburst: If the text doesn't fit - remove it
0c03751
Aleksashka11 added a commit that referenced this issue Aug 2, 2023
@Aleksashka11
#2098: Charts | Sunburst: Tooltips using showRowGroup
1ad0eff
@ahadzhanian
Copy link
Collaborator

@Aleksashka11 please check the molecule rendering

Data: sar_small (the first six rows)

Image

@ahadzhanian
Copy link
Collaborator

@Aleksashka11 Please check this issue: an error occurs when clicking the root node with 0 rows

Image

html_dart2js.dart:3558 2023-08-03 15:04:39.892 Cannot read properties of undefined (reading 'split')
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 214515:43  ECharts.<fn>
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 221923:33  Eventful.trigger
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 162865:17  ECharts.handler
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 221923:33  Eventful.trigger
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 217450:18  Handler.dispatchToElement
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 217550:14  Handler.<computed>
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 221923:33  Eventful.trigger
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 226154:14  localDOMHandlers.<computed>
	api/packages/published/files/Charts/1.1.1/2eIQ9gMFytrC5zuSwkxPy7IH9iRaACuh/4/dist/package.js 226201:50  HTMLDivElement.<fn>

Aleksashka11 added a commit that referenced this issue Aug 4, 2023
@Aleksashka11
#2098: Charts | Sunburst: An error when clicking on the root node
c5ec0df
MariaDolotova pushed a commit that referenced this issue Aug 4, 2023
@Aleksashka11
#2098: Charts | Sunburst: UI/UX improvements (sync with column color …
453d333 
…coding)
MariaDolotova pushed a commit that referenced this issue Aug 4, 2023
@Aleksashka11
#2098: Sunburst: If the text doesn't fit - remove it
2951ef2
MariaDolotova pushed a commit that referenced this issue Aug 4, 2023
@Aleksashka11
#2098: Charts | Sunburst: Tooltips using showRowGroup
28f0392
@ahadzhanian
Copy link
Collaborator

ahadzhanian commented Aug 5, 2023 •
edited

Please, note that it is possible to change the order of hierarchy levels. However, during the next configuration of the Hierarchy setting, the order of levels is restored according to the order of columns in the table. This limitation is inherent in the ECharts library.

Image

Aleksashka11 added a commit that referenced this issue Aug 5, 2023
@Aleksashka11
#2098: Charts | Sunburst: Minor fixes for tooltip, rendering
e5cf8d7
Aleksashka11 added a commit that referenced this issue Aug 7, 2023
@Aleksashka11
#2098: Charts | Sunburst: Render if column semtype is molecule
71b3bfd
@ahadzhanian
Copy link
Collaborator

Charts 1.2.0

Aleksashka11 added a commit that referenced this issue Aug 9, 2023
@Aleksashka11
#2098: Charts | Sunburst: Bump new version
8624fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aleksashka11 Aleksashka11

Labels
enhancement New feature or request NX NIBR-related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aleksashka11 @LaykDimon @ahadzhanian