Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2105: Curves: Outliers and curves colors changes #2105

Closed
3 tasks done
LaykDimon opened this issue Jun 29, 2023 — with Board Genius Sync · 5 comments
Closed
3 tasks done

#2105: Curves: Outliers and curves colors changes #2105

LaykDimon opened this issue Jun 29, 2023 — with Board Genius Sync · 5 comments
Assignees
Labels
enhancement New feature or request Neo

Comments

Copy link
Collaborator

LaykDimon commented Jun 29, 2023

  • Make outliers red color and much bigger size (TBD)
  • Add option for the outlier color
  • Make curves by default as a Datagrok categorical color, and if needed user can set his own color
@LaykDimon LaykDimon added enhancement New feature or request Neo labels Jun 29, 2023
@LaykDimon LaykDimon self-assigned this Jun 29, 2023
@LaykDimon
Copy link
Collaborator Author

@skalkin, as we spoke with @dgosi it turned out, that Neomorph used to see outliers as much bigger and red-color outliers
do we need to make this change for our Curves package?
also, @dgosi stated, that Neomorph doesn't use color settings in their curves, so I suggest to make by default different categorical colors, and if the user picks a color, he will use it

@LaykDimon LaykDimon changed the title Curves: Curves: Outliers and curves colors changes Jun 29, 2023
@skalkin
Copy link
Collaborator

skalkin commented Jun 29, 2023

I'm ok if the outliers are red (this could be an option) and bigger. Will need to see how it looks though.

@skalkin
Copy link
Collaborator

skalkin commented Jun 29, 2023

Regarding line colors - isn't that how it works already? We have a default color, then if there are multiple series we start adding colors from the categorical palette.

@LaykDimon
Copy link
Collaborator Author

if I remember correctly, it will just render the same color, but I will check this and fix if it's working like that

Copy link
Member

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-14877

@dnillovna dnillovna changed the title Curves: Outliers and curves colors changes #2105: Curves: Outliers and curves colors changes Feb 12, 2024
LaykDimon added a commit that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Neo
Projects
None yet
Development

No branches or pull requests

3 participants