Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned columns are not displayed properly with some row source options for the table #2117

Closed
katerina-stepanova opened this issue Jul 4, 2023 · 10 comments
Assignees
Labels
bug Something isn't working NX NIBR-related

Comments

@katerina-stepanova
Copy link
Collaborator

Steps to reproduce:

  1. Open a table
  2. Pin some columns
  3. Select one of the following options for table's row source:
  • Selected
  • MouseOverRow
  • MouseOverGroup
  • FilteredSelected
  • SelectedOrCurrent
  1. Use another viewer to change which rows are displayed in the table (select somthing, filter, mouse over etc.)

Expected results: Pinned columns area display the same rows as the main part of the table.

Actual results: Pinned columns area is not updated properly.
'MouseOverGroup' option (pinned columns are not updated at all):
2023-07-04_13-03-56 (1)
'Selected' option (pinned columns are updated on click on the pinned columns area, otherwise previous selection is displayed):
2023-07-04_13-05-50 (1)

@katerina-stepanova katerina-stepanova added the NX NIBR-related label Jul 4, 2023
@ahadzhanian ahadzhanian added the bug Something isn't working label Jul 4, 2023
dgosi pushed a commit that referenced this issue Jul 10, 2023
@dgosi
Copy link
Contributor

dgosi commented Jul 10, 2023

The fix for mouse over issue is available in v 1.1.25 of PowerGrid package. Selection or filtering from other viewers cause pinned column to update accordingly. No issue was observed.

@ahadzhanian
Copy link
Collaborator

ahadzhanian commented Jul 11, 2023

@dgosi Could you please specify the package version and let me know if there are any platform updates I need to wait for before testing? I'm still reproducing the bug on PowerGrid 1.1.25.
The data in the pinned columns is not updated until you hover over the grid.

Image

@dgosi
Copy link
Contributor

dgosi commented Jul 13, 2023

I am using dev server. Could you please describe the exact steps and the viewers to reproduce the issue? For me filtering, mouse over and selection do update pinned columns.

@ahadzhanian
Copy link
Collaborator

We can experience different behavior due to the operating system and browser differences. I use Windows 10, Chrome
To reproduce on dev:

  1. Open SPGI (I use Order and Hide columns to move the Chemist 521 column to the first position).
  2. Add a grid viewer:
  • Pin the Chemist 521 and ID columns
  • Set Row Source to Selected, MouseOverGroup, CurrentRow
  1. Select rows in the initial grid.
  2. Add a pie chart, hover over its groups
    Actual result: the data in the pinned columns is not updated until you hover over the grid

2117

dgosi pushed a commit that referenced this issue Jul 17, 2023
@dgosi
Copy link
Contributor

dgosi commented Jul 17, 2023

Thank you for providing the precise steps! MouseOverGroup and switching the rowSource property have been fixed. Everything else seems to work fine. All fixes are in v 1.1.27 of PowerGrid package.

@ahadzhanian
Copy link
Collaborator

I still reproduce a delay in updating pinned columns. In the GIF, I'm using Row Source set to MouseOverGroup
Image

@ahadzhanian ahadzhanian assigned LaykDimon and dgosi and unassigned dgosi Jul 25, 2023
LaykDimon added a commit that referenced this issue Aug 1, 2023
@ahadzhanian
Copy link
Collaborator

I still reproduce a delay in updating pinned columns, when Row Source is set to:

  • MouseOverRow
  • FilteredSelected or Selected
  • SelectedOrCurrent

Image
Image
Image

LaykDimon added a commit that referenced this issue Aug 4, 2023
@ahadzhanian
Copy link
Collaborator

PowerGrid 1.1.33

@ahadzhanian
Copy link
Collaborator

  1. Add 2nd table to the page besides the default grid and pin a couple of columns in it
  2. Configure this additional table to show FilteredSelected rows
  3. Select multiple rows
  4. Filter out some rows, so that additional table shows only 1-2 items
  5. Reset filter

Expected: table with row source FilteredSelected is re-rendered on resetting filters
Actual: pinned columns area is re-rendered only when one of the table on the page is hovered.

@ahadzhanian
Copy link
Collaborator

Fixed in DG 1.17, PowerGrid 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NX NIBR-related
Projects
None yet
Development

No branches or pull requests

4 participants