Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete exception work #137

Merged
merged 3 commits into from
May 26, 2020
Merged

Complete exception work #137

merged 3 commits into from
May 26, 2020

Conversation

akariv
Copy link
Member

@akariv akariv commented May 26, 2020

No description provided.

roll and others added 3 commits May 26, 2020 17:12
@roll @akariv
Added additional information to exceptions (#134)
f3dd15f 
* Added additional information to exceptions

* Updated implementation

Co-authored-by: Adam Kariv <akariv@users.noreply.github.com>
@akariv
Complete exceptions work on other dsp kinds
cc104c8
@akariv
Fix tests
e666ade
@coveralls
Copy link

coveralls commented May 26, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 474

  • 47 of 48 (97.92%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.584%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataflows/base/exceptions.py 12 13 92.31%
Totals Coverage Status
Change from base Build 467: 0.2%
Covered Lines: 1787
Relevant Lines: 2088
💛 - Coveralls

@akariv akariv merged commit 13a8489 into master May 26, 2020
@akariv akariv deleted the feature/exception-information branch May 26, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akariv @coveralls @roll