Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix full-outer join adding extraneous fields #165

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Fix full-outer join adding extraneous fields #165

merged 4 commits into from
Aug 23, 2021

Conversation

akariv
Copy link
Member

@akariv akariv commented Aug 23, 2021

Based on the issue found and partly fixed by @cschloer , fixing the case to full-outer joins are joined using differently named keys.

@akariv akariv merged commit 400b96f into master Aug 23, 2021
@akariv akariv deleted the test-join-fix branch August 23, 2021 18:39
@akariv akariv mentioned this pull request Aug 23, 2021
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 558

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.912%
Totals Coverage Status
Change from base Build 554: 0.02%
Covered Lines: 2178
Relevant Lines: 2565
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akariv @coveralls @cschloer