Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load infer, cast and error strategies #88

Merged
merged 3 commits into from
May 23, 2019
Merged

Conversation

akariv
Copy link
Member

@akariv akariv commented May 23, 2019

This PR generalizes the way that load infers and casts data types, deprecating the validate and force_strings arguments into three 'strategy' arguments: infer_strategy, cast_strategy and on_error (to decide what to do when validations errors occur).

See here for usage:
https://github.com/datahq/dataflows/pull/88/files#diff-0edecdf275b79739bdb4ca088cfb67e5R67

@coveralls
Copy link

Pull Request Test Coverage Report for Build 304

  • 35 of 40 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 83.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataflows/processors/load.py 34 39 87.18%
Totals Coverage Status
Change from base Build 303: -0.01%
Covered Lines: 1558
Relevant Lines: 1856

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 23, 2019

Pull Request Test Coverage Report for Build 309

  • 42 of 42 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 84.222%

Totals Coverage Status
Change from base Build 303: 0.3%
Covered Lines: 1564
Relevant Lines: 1857

💛 - Coveralls

@rufuspollock
Copy link
Member

@akariv what issue does this relate to? What is it adding? Wasn't super clearr.

@akariv akariv merged commit 0f10b94 into master May 23, 2019
@akariv
Copy link
Member Author

akariv commented May 23, 2019

@rufuspollock updated description of the PR, thanks :) !

@akariv akariv deleted the feature/load-strategies branch May 23, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants