Implement full outer join #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 327
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 327
💛 - Coveralls |
Pull Request Test Coverage Report for Build 334
💛 - Coveralls |
akariv
requested changes
Jun 5, 2019
dataflows/processors/join.py
Outdated
| db = KVFile() | ||
|
|
||
| # Joining mode | ||
| if mode is None: |
There was a problem hiding this comment.
if going with mode we should properly deprecate full
dataflows/processors/join.py
Outdated
|
|
||
| deduplication = target_key is None | ||
| fields = fix_fields(fields) | ||
| source_key = KeyCalc(source_key) | ||
| target_key = KeyCalc(target_key) if target_key is not None else target_key | ||
| db_keys = collections.OrderedDict() |
There was a problem hiding this comment.
generally you should use a KVFile here for memory scalability
dataflows/processors/join.py
Outdated
| continue | ||
| extra = dict( | ||
| (k, row.get(k)) | ||
| for k in fields.keys() | ||
| ) | ||
| row.update(extra) | ||
| yield row | ||
| if mode == 'full-outer': | ||
| for key in db_keys: | ||
| extra = db.get(key) |
dataflows/processors/join.py
Outdated
| @@ -324,16 +350,16 @@ def func(package: PackageWrapper): | |||
| return func | |||
|
|
|||
|
|
|||
| def join(source_name, source_key, target_name, target_key, fields={}, full=True, source_delete=True): | |||
| return join_aux(source_name, source_key, source_delete, target_name, target_key, fields, full) | |||
| def join(source_name, source_key, target_name, target_key, fields={}, full=True, mode=None, source_delete=True): | |||
There was a problem hiding this comment.
full should default to None and mode to 'inner'
if full is not None - show deprecation warning and update mode accordingly
There was a problem hiding this comment.
same comment applies to below functions as well
|
@akariv
|
|
This looks good @roll, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @akariv,
It's a first attempt to implement full outer join mode as asked here BCODMO/frictionless-usecases#12
If adding this functionality makes sense there are a few questions:
modeparameter (inner/half-outer/full-outer) because thefullflag can't cover all the options and slightly contradict to the SQL terminologydb_keyscache. Not sure will it be good enough using memory for DPPPlease take a look