Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added override_schema/fields to the load processor #99

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

roll
Copy link
Contributor

@roll roll commented Jun 28, 2019

@akariv
Please take a look. It's an initial try to implement this one - BCODMO/frictionless-usecases#6 (comment)

I'm not sure what the best naming solution:

  • current override_schema/fields
  • just schema/fields
  • some combined schema (could be confusing though)

PS.
It seems we don't need to add anything to DPP to propagate this change - https://github.com/frictionlessdata/datapackage-pipelines/blob/master/datapackage_pipelines/lib/load.py

@roll
Copy link
Contributor Author

roll commented Jun 28, 2019

cc @cschloer

@coveralls
Copy link

Pull Request Test Coverage Report for Build 337

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.315%

Totals Coverage Status
Change from base Build 332: 0.08%
Covered Lines: 1575
Relevant Lines: 1868

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 336

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.315%

Totals Coverage Status
Change from base Build 332: 0.08%
Covered Lines: 1575
Relevant Lines: 1868

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 337

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.315%

Totals Coverage Status
Change from base Build 332: 0.08%
Covered Lines: 1575
Relevant Lines: 1868

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 336

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 84.315%

Totals Coverage Status
Change from base Build 332: 0.08%
Covered Lines: 1575
Relevant Lines: 1868

💛 - Coveralls

@akariv akariv merged commit 42ad93e into datahq:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants