Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resources][m]: avoid duplication of original resources - fixes #41

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

zelima
Copy link
Collaborator

@zelima zelima commented Mar 14, 2018

This pull request fixes #40

PR fixes 2 main issue:

  • Avoids duplication of original and source/tabular resources
  • Keeps original resource for processing

Instead of duplicating resources before it was passed to add processing steps, Now we duplicate it right before adding them. So that if original data is not yet "tabular" (has no schema) it is still updated if the resource is present in 'processing' part of spec

@zelima zelima requested a review from akariv March 14, 2018 06:15
@zelima zelima merged commit 39fd799 into master Mar 14, 2018
@zelima zelima deleted the fix/deduplicate-resources branch March 14, 2018 06:18
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 82.736% when pulling 38b2a2e on fix/deduplicate-resources into ecbe76f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need of duplicated resources in zip and final dp.json
2 participants