fix(ingest): remove redundant types (#6486)

Possible since python/typeshed#9220 was merged. Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
datahub-project · Nov 21, 2022 · 490097e · 490097e
1 parent fdb74b0
commit 490097e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py
@@ -366,7 +366,7 @@ def get_long_description():
     # avrogen package requires this
     "types-pytz",
     "types-pyOpenSSL",
-    "types-click-spinner",
+    "types-click-spinner>=0.1.13.1",
     "types-ujson>=5.2.0",
     "types-termcolor>=1.0.0",
     "types-Deprecated",

diff --git a/metadata-ingestion/src/datahub/cli/docker_cli.py b/metadata-ingestion/src/datahub/cli/docker_cli.py
@@ -753,10 +753,7 @@ def quickstart(
     try:
         if pull_images:
             click.echo("Pulling docker images...")
-            # FIXME: Remove args once https://github.com/python/typeshed/pull/9220 is merged.
-            with click_spinner.spinner(
-                beep=False, disable=False, force=False, stream=sys.stdout
-            ):
+            with click_spinner.spinner():
                 subprocess.run(
                     [*base_command, "pull", "-q"],
                     check=True,

diff --git a/metadata-ingestion/src/datahub/cli/ingest_cli.py b/metadata-ingestion/src/datahub/cli/ingest_cli.py
@@ -118,9 +118,7 @@ def run_pipeline_to_completion(
         pipeline: Pipeline, structured_report: Optional[str] = None
     ) -> int:
         logger.info("Starting metadata ingestion")
-        with click_spinner.spinner(
-            beep=False, disable=no_spinner, force=False, stream=sys.stdout
-        ):
+        with click_spinner.spinner(disable=no_spinner):
             try:
                 pipeline.run()
             except Exception as e: