stop homepage flicker

datahub-project · Apr 22, 2022 · 5a43bfa · 5a43bfa
1 parent c5b8f57
commit 5a43bfa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/datahub-web-react/src/app/home/HomePageHeader.tsx b/datahub-web-react/src/app/home/HomePageHeader.tsx
@@ -17,6 +17,7 @@ import analytics, { EventType } from '../analytics';
 import { AdminHeaderLinks } from '../shared/admin/AdminHeaderLinks';
 import { ANTD_GRAY } from '../entity/shared/constants';
 import { useAppConfig } from '../useAppConfig';
+import { DEFAULT_APP_CONFIG } from '../../appConfigContext';
 
 const Background = styled.div`
     width: 100%;
@@ -196,7 +197,11 @@ export const HomePageHeader = () => {
             </Row>
             <HeaderContainer>
                 <Image
-                    src={appConfig.config.visualConfig.logoUrl || themeConfig.assets.logoUrl}
+                    src={
+                        appConfig.config !== DEFAULT_APP_CONFIG
+                            ? appConfig.config.visualConfig.logoUrl || themeConfig.assets.logoUrl
+                            : undefined
+                    }
                     preview={false}
                     style={styles.logoImage}
                 />

diff --git a/datahub-web-react/src/app/search/SearchHeader.tsx b/datahub-web-react/src/app/search/SearchHeader.tsx
@@ -10,6 +10,7 @@ import EntityRegistry from '../entity/EntityRegistry';
 import { ANTD_GRAY } from '../entity/shared/constants';
 import { AdminHeaderLinks } from '../shared/admin/AdminHeaderLinks';
 import { useAppConfig } from '../useAppConfig';
+import { DEFAULT_APP_CONFIG } from '../../appConfigContext';
 
 const { Header } = Layout;
 
@@ -82,7 +83,11 @@ export const SearchHeader = ({
             <LogoSearchContainer>
                 <Link to="/">
                     <LogoImage
-                        src={appConfig.config.visualConfig.logoUrl || themeConfig.assets.logoUrl}
+                        src={
+                            appConfig.config !== DEFAULT_APP_CONFIG
+                                ? appConfig.config.visualConfig.logoUrl || themeConfig.assets.logoUrl
+                                : undefined
+                        }
                         preview={false}
                     />
                 </Link>