refactor(pdl): Refactoring Assertion model enums out (#9191)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
datahub-project · Nov 8, 2023 · f87983d · f87983d
1 parent 70692b4
commit f87983d
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 24 deletions.
diff --git a/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResult.pdl b/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResult.pdl
@@ -9,24 +9,7 @@ record AssertionResult {
   */
   @TimeseriesField = {}
   @Searchable = {}
-  type: enum AssertionResultType {
-    /**
-    *  The Assertion has not yet been fully evaluated
-    */
-    INIT
-    /**
-    *  The Assertion Succeeded
-    */
-    SUCCESS
-    /**
-    *  The Assertion Failed
-    */
-    FAILURE
-    /**
-    *  The Assertion encountered an Error
-    */
-    ERROR
-  }
+  type: AssertionResultType
 
   /**
    * Number of rows for evaluated batch

diff --git a/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResultType.pdl b/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionResultType.pdl
@@ -0,0 +1,23 @@
+namespace com.linkedin.assertion
+
+/**
+*  The final result of evaluating an assertion, e.g. SUCCESS, FAILURE, or ERROR.
+*/
+enum AssertionResultType {
+  /**
+  *  The Assertion has not yet been fully evaluated
+  */
+  INIT
+  /**
+  *  The Assertion Succeeded
+  */
+  SUCCESS
+  /**
+  *  The Assertion Failed
+  */
+  FAILURE
+  /**
+  *  The Assertion encountered an Error
+  */
+  ERROR
+}
diff --git a/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunEvent.pdl b/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunEvent.pdl
@@ -39,12 +39,7 @@ record AssertionRunEvent {
   * The status of the assertion run as per this timeseries event.
   */
   @TimeseriesField = {}
-  status: enum AssertionRunStatus {
-    /**
-     * The Assertion Run has completed
-     */
-    COMPLETE
-  }
+  status: AssertionRunStatus
 
   /**
   * Results of assertion, present if the status is COMPLETE

diff --git a/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunStatus.pdl b/metadata-models/src/main/pegasus/com/linkedin/assertion/AssertionRunStatus.pdl
@@ -0,0 +1,12 @@
+namespace com.linkedin.assertion
+
+
+/**
+* The lifecycle status of an assertion run.
+*/
+enum AssertionRunStatus {
+  /**
+   * The Assertion Run has completed
+   */
+  COMPLETE
+}