Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalTags Aspect API returns HTTP Code 204 instead of 200 #10068

Closed
kzgrzendek opened this issue Mar 18, 2024 · 2 comments
Closed

GlobalTags Aspect API returns HTTP Code 204 instead of 200 #10068

kzgrzendek opened this issue Mar 18, 2024 · 2 comments
Labels
bug Bug report stale

Comments

@kzgrzendek
Copy link

kzgrzendek commented Mar 18, 2024

Hello,

First of all, I'd like to thank you for your amazing work! This issue is rather minor, but I thought I'd raise it anyway for you to have it in the backlog.

PS : I haven's see this behavior describe in other issues, sorry if it was already discussed elsewhere.

Describe the bug
On the 0.13.0 version of Datahub, when browsing the OpenAPI page to the HEAD [/v2/entity/dataproduct/{urn}/globaltags] operation of the GlobalTags Aspect, the API returns a HTTP 204 Code if GlobalTags for the corresponding DataProduct urn exists, but the documentation states that an HTTP 200 Code should be returned in that case.

Would it be possible to align the OpenAPI specification with the actual API behavior?

To Reproduce
Steps to reproduce the behavior:

  1. Open the OpenAPI - Swagger UI of the 0.13.0 version of DataHub
  2. Browse to the HEAD [/v2/entity/dataproduct/{urn}/globaltags] operation of the GlobalTags Aspect of the API.
  3. Search GlogalTags for a valid DataProduct urn containing at least one GlobalTag
  4. The API answers with a 204 HTTP return code, whereas the Swagger specifies that a 200 return code should be returned instead

Expected behavior
The API should return an HTTP 200 OK code in that scenario, or the Swagger should be updated to state that an HTTP 204 return code is the behavior to expect.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04 LTS
  • Browser: Firefox 122.0.1 (64 bits)
  • Version: 0.13.0

Additional context
None

@kzgrzendek kzgrzendek added the bug Bug report label Mar 18, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Apr 18, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report stale
Projects
None yet
Development

No branches or pull requests

1 participant