Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSL to mce_cli.py #1849

Closed
fabiofilz opened this issue Sep 3, 2020 · 3 comments
Closed

Support SSL to mce_cli.py #1849

fabiofilz opened this issue Sep 3, 2020 · 3 comments
Labels
feature-request Request for a new feature to be added

Comments

@fabiofilz
Copy link
Contributor

We are executing the step on https://github.com/linkedin/datahub/tree/master/metadata-ingestion, but the mce_cli.py (and other python apps) don't support SSL connection to Kafka.

A suggestion would be to use the same as kafka-topic.sh does:

kafka-topics --command-config kafka.config

Ex. kafka.config
ssl.truststore.location=./resources/keys/pt/pt.d2.aws.truststore.jks
ssl.truststore.password=XXXXXXXXXXXXX
ssl.keystore.location=./resources/keys/pt/pt.d2.aws.keystore.jks
ssl.keystore.password=XXXXXXXXXXXXXX
ssl.key.password=XXXXXXXXXXXXX
security.protocol=SSL

So the command could be:

python3 metadata-ingestion/mce-cli/mce_cli.py produce -l metadata-events/mxe-schemas/src/renamed/avro/com/linkedin/mxe/MetadataChangeEvent.avsc -d metadata-ingestion/mce-cli/bootstrap_mce.dat -b bootstrap.d2-pt.aws.com:9092 -s https://schemaregistry.d2-pt.aws.com:8443 -c kafka.config

Thank you.
Fabio

@fabiofilz fabiofilz added the feature-request Request for a new feature to be added label Sep 3, 2020
@mars-lan
Copy link
Contributor

mars-lan commented Sep 3, 2020

Makes sense. Would you be interested in creating a PR for this, @fabiofilz?

@jplaisted
Copy link
Contributor

fyi this is moving to contrib soon anyway. I'll be sure to keep this in mind for the Java port :)

@fabiofilz
Copy link
Contributor Author

Hi @mars-lan,

Please find the PR with SSL feature.

Thank you.
Fabio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature to be added
Projects
None yet
Development

No branches or pull requests

3 participants