feat(redshift): adds flag to skip all external tables #10040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
|
Some build checks fail because of unrelated stuff. If tests for the new feature are requested, could you please point out where these tests could be added? I'm pretty sure there are but I couldn't find them 😅 |
|
@treff7es can you give this a review, especially in the context of the redshift serverless changes that went in last week |
treff7es
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a mesh of redsfhit clusters where each of the clusters includes tables from the others as external tables. So everything is accessible from everywhere.
This causes lot of assset duplication in the catalogue. While we could prevent this with allow/deny pattern, with this flag we don't need to maintain the allow/deny patterns when new tables are added in any of the servers.
Checklist