fix(ui): show dataset display name in browse paths v2 #10054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the (new) browse paths v2 it is possible to have in theory any entity as part of the browse path by referencing it via its urn. Unfortunately the UI is currently not "requesting" the display name of the dataset entity as part of the browse path v2, therefore only the URN is shown.
Most of the time it makes no sense to have datasets as part of the browse path (e.g., if you think of SQL databases, most of the time you have databases or schemas, which are ingested as containers, but there is no entity "below" a dataset), but in case of SAP BW (we are still working on a source for it ;-)) it makes sense to also have a dataset as part of the browse path because of the special relationship between InfoProviders and Queries (Queries in SAP BW cannot be compared to SQL queries in SQL databases):
0BW (InfoArea -> Ingested as a container with subtype InfoArea)
0BWTCT_STA (InfoArea -> Ingested as a container with subtype InfoArea, 0BW as a parent container)
0BWTC_C10 (InfoProvider -> Ingested as a dataset with subtype InfoProvider and MultiProvider, 0BWTCT_STA as a container)
0BWTC_C10_Q001 (Query -> Ingested as a dataset with subtype Query, 0BWTCT_STA as a container)
Queries are defined on an InfoProvider and represent an own and persistent object (it is mostly comparable to a SQL view in SQL databases) and therefore have an upstream lineage aspect to the InfoProvider. Queries are always "shown" below an InfoProvider (the screenshot is taken from the modelling tools of SAP for SAP BW), therefore it also makes sense to show them below the InfoProvider in the browse path. However the container of the Query is not the InfoProvider, instead the Query has the same InfoArea as its InfoProvider.
Checklist