Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show dataset display name in browse paths v2 #10054

Conversation

Masterchen09
Copy link
Contributor

With the (new) browse paths v2 it is possible to have in theory any entity as part of the browse path by referencing it via its urn. Unfortunately the UI is currently not "requesting" the display name of the dataset entity as part of the browse path v2, therefore only the URN is shown.

Most of the time it makes no sense to have datasets as part of the browse path (e.g., if you think of SQL databases, most of the time you have databases or schemas, which are ingested as containers, but there is no entity "below" a dataset), but in case of SAP BW (we are still working on a source for it ;-)) it makes sense to also have a dataset as part of the browse path because of the special relationship between InfoProviders and Queries (Queries in SAP BW cannot be compared to SQL queries in SQL databases):

image

0BW (InfoArea -> Ingested as a container with subtype InfoArea)
0BWTCT_STA (InfoArea -> Ingested as a container with subtype InfoArea, 0BW as a parent container)
0BWTC_C10 (InfoProvider -> Ingested as a dataset with subtype InfoProvider and MultiProvider, 0BWTCT_STA as a container)
0BWTC_C10_Q001 (Query -> Ingested as a dataset with subtype Query, 0BWTCT_STA as a container)

Queries are defined on an InfoProvider and represent an own and persistent object (it is mostly comparable to a SQL view in SQL databases) and therefore have an upstream lineage aspect to the InfoProvider. Queries are always "shown" below an InfoProvider (the screenshot is taken from the modelling tools of SAP for SAP BW), therefore it also makes sense to show them below the InfoProvider in the browse path. However the container of the Query is not the InfoProvider, instead the Query has the same InfoArea as its InfoProvider.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 14, 2024
@samblackk samblackk self-requested a review March 19, 2024 17:25
@samblackk samblackk self-assigned this Mar 22, 2024
@samblackk samblackk merged commit 13f4993 into datahub-project:master Mar 22, 2024
37 checks passed
@Masterchen09 Masterchen09 deleted the fix-dataset-urn-in-browse-paths-v2 branch April 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants