New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): respect the search flags term bucket size #10130

Merged

david-leifker merged 1 commit into datahub-project:master from david-leifker:fix-term-bucket-agg-flags

Mar 25, 2024

Collaborator

david-leifker commented Mar 25, 2024 •

edited

Take into account the searchFlags max bucket when specified,

    int maxTermBuckets =
        Math.min(
            opContext.getSearchContext().getSearchFlags().getMaxAggValues(),
            configs.getMaxTermBucketSize());

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

github-actions bot added the product label

david-leifker requested a review from RyanHolstien

March 25, 2024 21:57


          fix(search): respect the search flags term bucket size

f00ca1f

david-leifker force-pushed the fix-term-bucket-agg-flags branch from 60c8863 to f00ca1f Compare

March 25, 2024 22:04

RyanHolstien approved these changes

View reviewed changes

vercel bot deployed to Preview

March 25, 2024 22:24

View deployment

david-leifker merged commit fc03a1c into datahub-project:master

41 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment