Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/dynamodb): add support for classification #10138

Merged
merged 4 commits into from
Mar 27, 2024
Merged

feat(ingest/dynamodb): add support for classification #10138

merged 4 commits into from
Mar 27, 2024

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 26, 2024
hsheth2
hsheth2 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, had one comment

metadata-ingestion/src/datahub/ingestion/glossary/classification_mixin.py
isinstance(wu.metadata, MetadataChangeEvent)
and len(wu.metadata.proposedSnapshot.aspects) > 1
) or not maybe_schema_metadata:
yield wu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we remove the SchemaMetadata aspect from the snapshot, since we're emitting it after

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, this is leaving the MCEs as is and not processing it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In followup, I am planning to add support for classifying SchemaMetadata in MCE and refractoring sql_common to use this.

@hsheth2 hsheth2 merged commit 0361f24 into datahub-project:master Mar 27, 2024
56 of 57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@mayurinehate @sleeperdeep
feat(ingest/dynamodb): add support for classification (datahub-projec…
682d516 
…t#10138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @hsheth2