feat(ui): Adding new analytics charts for new users, top users past month #10344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshbansal
reviewed
Apr 23, 2024
Comment on lines
+23
to
+28
| @Searchable = { | ||
| "/time": { | ||
| "fieldName": "statusLastModifiedAt", | ||
| "fieldType": "COUNT" | ||
| } | ||
| } |
There was a problem hiding this comment.
you need a backfill job otherwise it won't work for existing deployments. This would mean for a month the charts will be empty.
There was a problem hiding this comment.
see comments below
anshbansal
reviewed
Apr 23, 2024
| .filter(row -> !row.getCells().isEmpty()) | ||
| .map(row -> UrnUtils.getUrn(row.getCells().get(0).getValue())) | ||
| .collect(Collectors.toSet()); | ||
| final Map<Urn, EntityResponse> gmsResponseByUser = |
There was a problem hiding this comment.
Might be a good idea to add a check for userUrns size before making these calls. No need to make these calls in case this is empty.
anshbansal
approved these changes
Apr 23, 2024
anshbansal
added
the
merge-pending-ci
|
i did not plan to do a backfill job. this will delay the PR further and higher priorities. if we decide on backfill it will take another 3 days before i have it ready i'll let the primary stakeholder (@gabe-lyons) make the final call on whether to delay or not. |
gabe-lyons
approved these changes
Apr 24, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…onth (datahub-project#10344) Co-authored-by: John Joyce <john@Johns-MBP-251.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add 2 basic charts to analytics tabs:
This includes their name, title, and email for reference.
Checklist