fix(lineage) Fix lineage source/dest filtering with explored per hop limit

[chriscollins3456]

There was a bug in how we were filtering when using the entitiesExploredPerHopLimit where we needed to reverse the source and dest filter depending on the lineage direction we were going. Without this fix we weren't matching on things like dataJobs in searchAcrossLineage down this path properly.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features
  • Enhanced query filtering with direction-based relationship support.

[coderabbitai]

Walkthrough

The core change in the ESGraphQueryDAO.java involves the getAggregationFilter method, which now includes an additional RelationshipDirection direction parameter. This modification enables the method to dynamically adjust source and destination types based on the specified relationship direction, enhancing the flexibility and accuracy of query filter construction.

Changes

File	Change Summary
`metadata-io/src/main/java/com/linkedin/metadata/graph/...	Modified the getAggregationFilter method to include a RelationshipDirection direction parameter that influences query construction based on relationship direction.

Poem

In ESGraph's realm, a change so clear,
A direction added, pathways appear.
Queries now smart, they weave and flow,
With source and destination, watch them grow.
A rabbit's code, now more refined,
Adding wisdom to the digital mind.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 609847f and 6a17c71.

Files selected for processing (1)

• metadata-io/src/main/java/com/linkedin/metadata/graph/elastic/ESGraphQueryDAO.java (2 hunks)

Additional comments not posted (2)

metadata-io/src/main/java/com/linkedin/metadata/graph/elastic/ESGraphQueryDAO.java (2)

234-235: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to getAggregationFilter correctly pass the new direction parameter.

---

241-249: Correct handling of relationship direction.

The use of the direction parameter to determine the source and destination types based on the relationship direction is appropriate and addresses the filtering issue.