Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oracle driver #1613

Merged
merged 1 commit into from Mar 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions contrib/metadata-ingestion/README.md
Expand Up @@ -12,8 +12,8 @@ i split the ingestion procedure to two part: [datahub-producer] and different [m

- [X] datahub-producer load json avro data.
- [X] add lineage-hive generator
- [X] add dataset-jdbc generator[include [mysql, mssql, postgresql] driver]
- [ ] enhance dataset-jdbc generator [oracle-driver]
- [X] add dataset-jdbc generator[include [mysql, mssql, postgresql, oracle] driver]
- [ ] enhance dataset-jdbc generator [hive-driver]
- [ ] enhance lineage-jdbc generator to lazy iterator mode.
- [ ] add lineage-oracle generator
- [ ] enchance avro parser to show error information
Expand Down Expand Up @@ -42,7 +42,7 @@ i split the ingestion procedure to two part: [datahub-producer] and different [m
ls sample/hive_*.sql | bin/lineage_hive_generator.hs | bin/datahub-producer.hs config
```

4. load jdbc schema(mysql, mssql, postgresql) to datahub [
4. load jdbc schema(mysql, mssql, postgresql, oracle) to datahub
```
bin/dataset-jdbc-generator.hs | bin/datahub-producer.hs config
```
7 changes: 6 additions & 1 deletion contrib/metadata-ingestion/bin/dataset-jdbc-generator.hs
Expand Up @@ -133,7 +133,12 @@ main = do
dbUrl :: T.Text = "jdbc:mysql://localhost:3306/datahub?useSSL=false"
dbUser :: T.Text = "datahub"
dbPassword :: T.Text = "datahub"
dbDriver :: T.Text = "com.mysql.jdbc.Driver"

-- dbDriver:: T.Text = "oracle.jdbc.OracleDriver" ;
dbDriver:: T.Text = "com.mysql.jdbc.Driver" ;
-- dbDriver:: T.Text = "org.postgresql.Driver" ;
-- dbDriver:: T.Text = "com.microsoft.sqlserver.jdbc.SQLServerDriver" ;

dbSQL :: T.Text = datasetMysqlSql
runInBoundThread $ withJVM jvmArgs $ do
[jDbUrl, jDbUser, jDbPassword, jDbDriver, jDbSQL ] <-
Expand Down
Expand Up @@ -38,6 +38,7 @@ mkShell {
pkgs.postgresql_jdbc
pkgs.mysql_jdbc
pkgs.mssql_jdbc
pkgs.oracle-instantclient

(haskellPackages.ghcWithPackages ( p:
[ p.bytestring p.string-conversions
Expand Down