Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to mce_cli #1868

Merged
merged 1 commit into from Sep 11, 2020
Merged

Small fixes to mce_cli #1868

merged 1 commit into from Sep 11, 2020

Conversation

jplaisted
Copy link
Contributor

@jplaisted jplaisted commented Sep 10, 2020 •
edited

  • default argument value should be None not "None"
  • Test data should have corpuser, not corpUser (case sensitive)

fixes #1867
fixes #1865

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Small fixes to mce_cli
0bd5076 
- default argument value should be None not "None"
- Test data should have corpuser, not corpUser (case sensitive)

fixes #1867
fixes #1865
@jplaisted jplaisted merged commit 23ad0e9 into datahub-project:master Sep 11, 2020
@jplaisted jplaisted deleted the smallfixes branch September 11, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars-lan mars-lan mars-lan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ownership on ES not working via mce_cli mce_cli produce throws an error
2 participants
@jplaisted @mars-lan