Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Adds UI support for custom dataset properties #1905

Merged
merged 1 commit into from Oct 2, 2020

Conversation

cptran777
Copy link
Contributor

@cptran777 cptran777 commented Sep 30, 2020

This PR is the final piece to address a feature request for custom dataset properties.

Please reference #1881 for how the sample data should look when ingested. The presentation is currently a basic table configured to read key value pairs.

Issues Addressed

Fixes #1730

Testing done

Will rely on build to ensure that tests still pass.

Spun up docker images and ensured that application still built and behaved correctly with the mock data. Reference image below:

Screen Shot 2020-09-29 at 5 02 21 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cptran777
Copy link
Contributor Author

@cobolbaby @jsotelo sorry for the delay, it was a long journey to be able to get to this point :)

@jsotelo
Copy link
Contributor

jsotelo commented Sep 30, 2020

@cobolbaby @jsotelo sorry for the delay, it was a long journey to be able to get to this point :)

No worries, much appreciated!

@cptran777
Copy link
Contributor Author

Since no issues have been raised thus far, will go ahead and merge. Please raise any issues that may arise after the merge. Thanks!

@cptran777 cptran777 merged commit 8d30bd4 into master Oct 2, 2020
@cptran777 cptran777 deleted the fe-custom-dataset-properties branch October 2, 2020 18:26
@nagarjunakanamarlapudi nagarjunakanamarlapudi added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI support for customProperties in DatasetProperties aspect
3 participants