Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata-ingestion): Fix auditStamp unix timestamp format in sql etl ingestion #1918

Merged
merged 1 commit into from Oct 6, 2020

Conversation

grantatspothero
Copy link
Contributor

Datahub was expecting this timestamp to be in milliseconds since epoch, not seconds. This change makes the lastModified timestamp render correctly in the UI when it is converted to a datetime string.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable). Not applicable.
  • Tests for the changes have been added/updated (if applicable). Not applicable.
  • Docs related to the changes have been added/updated (if applicable). Not applicable.

…etl ingestion

Datahub was expecting this timestamp to be in milliseconds since epoch, not seconds. This change makes the lastModified timestamp render correctly in the UI when it is converted to a date time string.
@mars-lan mars-lan added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 6, 2020
@mars-lan mars-lan merged commit fa58c2d into datahub-project:master Oct 6, 2020
@grantatspothero grantatspothero deleted the patch-1 branch October 6, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants