refactor(dao/utils): Move general createRelationshipFilter from Neo4jUtil to QueryUtils #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
changed the title
jjoyce0510
reviewed
Aug 17, 2021
EnricoMi
force-pushed
the
branch-move-create-relationship-filter
branch
2 times, most recently
from
3853d1a
to
d89d861
Compare
gabe-lyons
reviewed
Aug 19, 2021
build.gradle
Outdated
| @@ -1,6 +1,6 @@ | |||
| buildscript { | |||
| ext.junitJupiterVersion = '5.6.1' | |||
| ext.gmaVersion = '0.2.80' | |||
| ext.gmaVersion = '0.3.0' | |||
There was a problem hiding this comment.
after making the versioning change I suggested in datahub-gma, we'll want this to be more like 0.2.81 👍
EnricoMi
force-pushed
the
branch-move-create-relationship-filter
branch
from
d89d861
to
1ac3827
Compare
EnricoMi
force-pushed
the
branch-move-create-relationship-filter
branch
from
1ac3827
to
393fa96
Compare
EnricoMi
force-pushed
the
branch-move-create-relationship-filter
branch
from
393fa96
to
22bc5ba
Compare
|
@gabe-lyons this is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods that are not Neo4j-specific are moved out of Neo4Util in datahub-gma in linkedin/datahub-gma#121. This removes Neo4jUtil imports from classes that have no other reference to neo4j.
Besides moving these two methods into QueryUtils, this renames them to match existing methods in the target utils class.