Java11 Prerequisites #4340
Merged
Java11 Prerequisites #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with upstream
4 tasks
dleifkerz
reviewed
Mar 7, 2022
| @@ -1,6 +1,6 @@ | |||
| buildscript { | |||
| ext.junitJupiterVersion = '5.6.1' | |||
| ext.pegasusVersion = '28.3.7' | |||
| ext.pegasusVersion = '29.22.16' | |||
There was a problem hiding this comment.
This was bumped to support gradle 6, the old version did not support it. Decided to conservatively increase this version to what appeared to be the latest stable 29.x without moving to the very latest 30.x. Didn't want to move too fast here.
dleifkerz
reviewed
Mar 7, 2022
| @@ -110,6 +110,9 @@ shadowJar { | |||
| relocate 'org.abego.treelayout', 'datahub.shaded.treelayout' | |||
| relocate 'org.slf4j', 'datahub.shaded.slf4j' | |||
| relocate 'javax.annotation', 'datahub.shaded.javax.annotation' | |||
| relocate 'com.github.benmanes.caffeine', 'datahub.shaded.com.github.benmanes.caffeine' | |||
There was a problem hiding this comment.
These were added due to the bump in pegasus version here.
dleifkerz
reviewed
Mar 7, 2022
| @@ -16,7 +16,7 @@ | |||
| /** | |||
| * In memory ranker that re-ranks results returned by the search backend | |||
| */ | |||
| public abstract class SearchRanker { | |||
| public abstract class SearchRanker<U extends Comparable<? super U>> { | |||
RyanHolstien
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
LGTM, changes look pretty straightforward. @shirshanka can we get a forced build execution since this is a first time contribution? Assuming the build goes through I think this is good to go. CI shouldn't need any updates for these prereqs.
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key motivation is to update build process and a couple classes for java 11 compatibility.
The default JDK must remain java8 until the spark-lineage module upgrades from Spark 2.x as it has a hard dependency on the java 8 jvm. It is not possible to use the
--releaseflag in later jvms and run spark 2.4 tests.In order to keep java8 as the default and selectively use java11 we upgrade to gradle 6 with support for toolchains. This allows us to include both java8 and java11 modules, as long as java8 modules do not depend on java11. The reverse is possible, java11 modules can depend on java8 modules.
Checklist