Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): Add config to improve user exp for initial ingestion and fix docs #4510

Merged
merged 5 commits into from Mar 29, 2022
Merged

feat(ingest): Add config to improve user exp for initial ingestion and fix docs #4510

merged 5 commits into from Mar 29, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited

Unit Test Results (build & test)

  93 files    93 suites   16m 55s ⏱️
676 tests 617 ✔️ 59 💤 0 ❌

Results for commit 01e61c2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   55m 34s ⏱️ + 8m 6s
   388 tests +17     388 ✔️ +17    0 💤 ±0  0 ❌ ±0 
1 787 runs  +85  1 756 ✔️ +92  31 💤  - 7  0 ❌ ±0 

Results for commit 01e61c2. ± Comparison against base commit 6b04dff.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal changed the title feat(ingest): Change defaults to improve user exp for initial ingestion and fix docs feat(ingest): Add config to improve user exp for initial ingestion and fix docs Mar 28, 2022
@anshbansal anshbansal closed this Mar 29, 2022
@anshbansal anshbansal reopened this Mar 29, 2022
rslanka
rslanka approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit d30b6e1 into datahub-project:master Mar 29, 2022
@anshbansal anshbansal deleted the change-defaults-snowflake branch July 21, 2022 12:11
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat(ingest): Add config to improve user exp for initial ingestion an…
3a7d4c6 
…d fix docs (datahub-project#4510)

* feat(snowflake): change defaults to improve user experience for initial ingestion + documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anshbansal @rslanka