Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update default cli for managed ingestion #4581

Merged
merged 3 commits into from Apr 5, 2022
Merged

chore: update default cli for managed ingestion #4581

merged 3 commits into from Apr 5, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

@treff7es
Copy link
Contributor

treff7es commented Apr 5, 2022

lgtm

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Unit Test Results (build & test)

  95 files   - 1    95 suites   - 1   19m 26s ⏱️ - 1m 48s
681 tests  - 6  621 ✔️  - 7  59 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 843bbfe. ± Comparison against base commit c30b473.

jjoyce0510
jjoyce0510 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to ship for now - we also need to remember to update for M1 Quickstart!

@jjoyce0510 jjoyce0510 merged commit 32349bf into datahub-project:master Apr 5, 2022
@anshbansal anshbansal deleted the update-default-cli-for-quickstart branch April 6, 2022 05:33
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
chore: update default cli for managed ingestion (datahub-project#4581)
d549460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anshbansal @treff7es @jjoyce0510