feat(tableau): add some logic to normalize table names in tableau #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (build & test) 76 files - 20 76 suites - 20 1h 3m 1s ⏱️ + 47m 55s For more details on these failures, see this check. Results for commit e4f627c. ± Comparison against base commit 12f9cc2. ♻️ This comment has been updated with latest results. |
rslanka
approved these changes
Apr 7, 2022
5 tasks
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…tahub-project#4609) * add some logic to normalize table names in tableau
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tableau connector sometimes gives us table names that don't play well with other connectors when converted to urns. This PR adds some small tweaks to get our tableau urns to line up.
Checklist