Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): add missing workunit ids #4657

Merged

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Apr 13, 2022

Noticed this when running kafka source. Then checked the original PR #4496 by @shirshanka and noticed the same problem in sql_common. So fixed that too. Should help a bit during debugging.

As this is log in reporting tests are not applicable in my opinion.

Checklist

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  +  45    96 suites  +45   19m 25s ⏱️ - 3m 7s
689 tests +380  630 ✔️ +328  59 💤 +52  0 ±0 

Results for commit 1dbeaca. ± Comparison against base commit f99d27f.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 1m 25s ⏱️ - 2m 8s
   429 tests ±0     429 ✔️ ±  0    0 💤 ±  0  0 ±0 
2 070 runs  ±0  2 024 ✔️ +20  46 💤  - 20  0 ±0 

Results for commit 1dbeaca. ± Comparison against base commit f99d27f.

Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 155209f into datahub-project:master Apr 13, 2022
@anshbansal anshbansal deleted the fix-report-missing-workunitids branch April 13, 2022 08:26
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants