Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oidc): add configurable read timeout #5088

Merged
merged 4 commits into from Jun 6, 2022
Merged

feat(oidc): add configurable read timeout #5088

merged 4 commits into from Jun 6, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited

Unit Test Results (build & test)

337 tests  +3   337 ✔️ +3   2m 56s ⏱️ -12s
  81 suites +3       0 💤 ±0 
  81 files   +3       0 ❌ ±0 

Results for commit 3b89203. ± Comparison against base commit 64fae61.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Jun 6, 2022
View reviewed changes
datahub-frontend/test/utils/SearchUtilTest.java Outdated

import static org.junit.Assert.*;

public class SearchUtilTest {
@Test
@Tedatahub-frontend/test/utils/SearchUtilTest.javast
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

@jjoyce0510 jjoyce0510 merged commit 2171595 into datahub-project:master Jun 6, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@RyanHolstien @maggiehays
feat(oidc): add configurable read timeout (datahub-project#5088)
9b2321d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyanHolstien @jjoyce0510