Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): presto-on-hive - not failing on Hive type parsing error #6118

Merged
merged 5 commits into from Oct 5, 2022
Merged

fix(ingest): presto-on-hive - not failing on Hive type parsing error #6118

merged 5 commits into from Oct 5, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Oct 4, 2022 •
edited

  • Not failing on Hive type parsing error
  • Remove duplicate entries from hive struct type when parsing

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
- Not failing in Hive type parsing error
2267f77 
- Remove duplicate entries from hive struct type when parsing
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 4, 2022
@treff7es treff7es changed the title not failing in Hive type parsing error fix(ingest): presto-on-hive - not failing on Hive type parsing error Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022 •
edited

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 53s ⏱️ - 4m 30s
   723 tests +4     720 ✔️ +4  3 💤 ±0  0 ❌ ±0 
1 448 runs  +8  1 442 ✔️ +8  6 💤 ±0  0 ❌ ±0 

Results for commit 59f2861. ± Comparison against base commit 3c0f63c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022 •
edited

Unit Test Results (build & test)

591 tests  +7   587 ✔️ +7   13m 21s ⏱️ +30s
146 suites +3       4 💤 ±0 
146 files   +3       0 ❌ ±0 

Results for commit 59f2861. ± Comparison against base commit 3c0f63c.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka self-assigned this Oct 5, 2022
shirshanka
shirshanka approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will wait for CI to be green before merging.

@shirshanka shirshanka merged commit 2f79b50 into datahub-project:master Oct 5, 2022
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@treff7es @shirshanka @david-leifker
fix(ingest): presto-on-hive - not failing on Hive type parsing error (d…
2b2843a 
…atahub-project#6118)

Co-authored-by: Shirshanka Das <shirshanka@apache.org>
@treff7es treff7es deleted the graceful_hive_type_conversion_failure branch February 8, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees

@shirshanka shirshanka

Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@treff7es @shirshanka