feat(ingest): replace base85's pickle with json #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous base85 implementation used pickle to serialize and deserialize state. This would cause issues if the state model ever changed.
github-actions
bot
added
the
ingestion
shirshanka
reviewed
Oct 13, 2022
david-leifker
approved these changes
Oct 13, 2022
anthonyhungnguyen
pushed a commit
to anthonyhungnguyen/zlp-datahub
that referenced
this pull request
Nov 8, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous base85 implementation used pickle to serialize and deserialize state. This would throw an error if the state model ever changed. See this SO answer for context on pickle's lack of backwards compatibility: https://stackoverflow.com/questions/64894061/renaming-python-package-with-backwards-compatibility-for-pickle.
Other benefits:
Checklist