Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/tableau): support dashboard tags #6185

Merged
merged 2 commits into from Oct 12, 2022
Merged

feat(ingest/tableau): support dashboard tags #6185

merged 2 commits into from Oct 12, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 12, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2022
@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited

Unit Test Results (metadata ingestion)

       8 files         8 suites   56m 54s ⏱️
   732 tests    730 ✔️ 2 💤 0 ❌
1 466 runs  1 462 ✔️ 4 💤 0 ❌

Results for commit c7db7da.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2022 •
edited

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   11m 42s ⏱️ -13s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit c7db7da. ± Comparison against base commit c0d42de.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 mentioned this pull request Oct 12, 2022
Merged
5 tasks
treff7es
treff7es approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsheth2 hsheth2 merged commit c7cc0af into datahub-project:master Oct 12, 2022
@hsheth2 hsheth2 deleted the tableau-dashboard-tags branch October 12, 2022 22:34
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest/tableau): support dashboard tags (datahub-project#6185)
3fa0a33
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
feat(ingest/tableau): support dashboard tags (datahub-project#6185)
1cbe60a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @treff7es