Worked on the Usage column & Lineage Drawer #6290
Conversation
| @@ -161,6 +161,7 @@ export default function SchemaTable({ | |||
| dataIndex: 'fieldPath', | |||
| key: 'usage', | |||
| render: usageStatsRenderer, | |||
| sorter: (sourceA, sourceB) => sourceA.name.localeCompare(sourceB.name), | |||
There was a problem hiding this comment.
I believe we would want to sort this by the count of the usage column and not the name. I'm actually not even sure what name would be in this situation here?
There was a problem hiding this comment.
yeah when I try to use this code to sort, I get a runtime error and react breaks. were you able to find any data locally with usage to test this on?
There was a problem hiding this comment.
I believe you're going to have to write a function that takes into account usageStats above and finds the fields you're sorting and then sorts by count that you find by field in usageStats above.
| @@ -192,6 +192,7 @@ export const AccessTokens = () => { | |||
| <span>{`${formattedExpireAt.toLocaleDateString()} at ${formattedExpireAt.toLocaleTimeString()} (${localeTimezone})`}</span> | |||
| ); | |||
| }, | |||
| sorter: (sourceA, sourceB) => sourceA.name.localeCompare(sourceB.name), | |||
There was a problem hiding this comment.
same questions here... why are you sorting by name for the "Expires At" column? shouldn't we be sorting based on that date for this column?
Checklist