Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spark-lineage): Smoke test fix + smoke test m1 support #6372

Merged
merged 2 commits into from
Nov 5, 2022
Merged

fix(spark-lineage): Smoke test fix + smoke test m1 support #6372

merged 2 commits into from
Nov 5, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Nov 5, 2022

M1 support
Updating smoke test golden files

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
M1 support
2c22202 
Updating smoke test golde files
@github-actions
Copy link

github-actions bot commented Nov 5, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 0s ⏱️ +16s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit aa5a1d8. ± Comparison against base commit 4c6dd06.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great :)

@shirshanka shirshanka merged commit 8cfcefb into datahub-project:master Nov 5, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
@treff7es
fix(spark-lineage): smoke test fixes, M1 support (datahub-project#6372)
0f667da
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@treff7es @cccs-Dustin
fix(spark-lineage): smoke test fixes, M1 support (datahub-project#6372)
7264555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@treff7es @shirshanka @david-leifker