Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): unity - add missing date type #6385

Merged
merged 2 commits into from
Nov 9, 2022
Merged

fix(ingest): unity - add missing date type #6385

merged 2 commits into from
Nov 9, 2022

Conversation

ms32035
Copy link
Contributor

@ms32035 ms32035 commented Nov 8, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   59m 36s ⏱️
   757 tests    754 ✔️ 3 💤 0 ❌
1 516 runs  1 509 ✔️ 7 💤 0 ❌

Results for commit 4a0a718.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 45s ⏱️ -2s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 4a0a718. ± Comparison against base commit 9be00e9.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

treff7es
treff7es approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 44cfc29 into datahub-project:master Nov 9, 2022
@ms32035 ms32035 deleted the trino_date branch November 9, 2022 17:14
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@ms32035 @cccs-Dustin
fix(ingest): unity - add missing date type (datahub-project#6385)
a9a2ffd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ms32035 @treff7es