Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/s3): add status aspect for detected s3 datasets #6402

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix(ingest/s3): add status aspect for detected s3 datasets #6402

merged 1 commit into from
Nov 14, 2022

Conversation

mayurinehate
Copy link
Collaborator

Issue reported on slack

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 10, 2022
@mayurinehate mayurinehate changed the title feat(s3): add status aspect for detected s3 datasets fix(ingest/s3): add status aspect for detected s3 datasets Nov 10, 2022
@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 29s ⏱️ - 3m 15s
   757 tests ±0     754 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 516 runs  ±0  1 509 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 43d4b79. ± Comparison against base commit 1b739319.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 4s ⏱️ +23s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 43d4b79. ± Comparison against base commit 1b739319.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit e79b4e8 into datahub-project:master Nov 14, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
feat(ingest): s3 - add status aspect for detected s3 datasets (datahu…
22232bc 
…b-project#6402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @shirshanka