Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): handle error when query returns no columns in snowflake lineage #6404

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

mayurinehate
Copy link
Collaborator

Currently, if columns are returned as None from snowflake query, such error is thrown -
TypeError: the JSON object must be str, bytes or bytearray, not NoneType

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 10, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 27s ⏱️ - 2m 59s
   757 tests ±0     754 ✔️ ±0  3 💤 ±0  0 ±0 
1 516 runs  ±0  1 509 ✔️ ±0  7 💤 ±0  0 ±0 

Results for commit bb4c67d. ± Comparison against base commit ae2ea52.

@github-actions
Copy link

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 24s ⏱️ +26s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ±0 

Results for commit bb4c67d. ± Comparison against base commit ae2ea52.

@hsheth2 hsheth2 merged commit 1b73931 into datahub-project:master Nov 10, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants