Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix missing snowflake lineage when table_pattern is set #6410

Merged
merged 2 commits into from
Nov 11, 2022
Merged

fix(ingest): fix missing snowflake lineage when table_pattern is set #6410

merged 2 commits into from
Nov 11, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 11, 2022
@github-actions
Copy link

github-actions bot commented Nov 11, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 45s ⏱️ +4s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit b3bceb0. ± Comparison against base commit 1b739319.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 11, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 14s ⏱️ - 2m 30s
   757 tests ±0     754 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 516 runs  ±0  1 509 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit b3bceb0. ± Comparison against base commit 1b739319.

♻️ This comment has been updated with latest results.

treff7es
treff7es reviewed Nov 11, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_utils.py
@@ -37,6 +37,9 @@ def get_dataset_identifier(
) -> str:
...

def get_dataset_identifier_from_qualified_name(self, qualified_name: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any implementation or why it is just ...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this Protocol class is only for mypy. This is required if using mixin classes, without actually doing inheritance. Reference - https://mypy.readthedocs.io/en/latest/more_types.html#mixin-classes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this comment in the code as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

treff7es
treff7es approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 6c42064 into datahub-project:master Nov 11, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
fix(ingest): snowflake - fix missing snowflake lineage when table_pat…
9aedb54 
…tern is set (datahub-project#6410)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayurinehate @treff7es