fix(roles): allows role service to unassign roles

[aditya-radhakrishnan]

Screenshot

Admins can now remove roles, or send an invite link with No Role attached to remove a role from a user

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[github-actions]

Unit Test Results (build & test)

621 tests   - 1   617 ✔️  - 1   15m 43s ⏱️ -20s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 18ea936. ± Comparison against base commit 1fe0f01.

This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both.

com.datahub.authorization.RoleServiceTest ‑ testAssignRoleToActorDoesNotExist
com.datahub.authorization.RoleServiceTest ‑ testAssignRoleToActorExists
com.datahub.authorization.RoleServiceTest ‑ testRoleDoesNotExist
com.datahub.authorization.RoleServiceTest ‑ testRoleExists
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testAllActorsExist
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testRoleDoesNotExistFails
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testSomeActorsExist

com.datahub.authorization.RoleServiceTest ‑ testAssignNullRoleToActorAllActorsExist
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleAllActorsExist
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleNoActorExists
com.datahub.authorization.RoleServiceTest ‑ testBatchAssignRoleSomeActorExists
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testNotNullRole
com.linkedin.datahub.graphql.resolvers.role.BatchAssignRoleResolverTest ‑ testNullRole

♻️ This comment has been updated with latest results.

[aditya-radhakrishnan]

Big shout out to @samanthafigueredo5 for catching two bugs here - not reflecting cancellation of role assignment, and fixing up the listRoles query made on the frontend! We really appreciate it :)

[chriscollins3456]

looking solid to me!