Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): handle missing schema in transformer #6445

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix(ingest): handle missing schema in transformer #6445

merged 2 commits into from
Nov 16, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 15, 2022 •
edited
Loading

Handles the case when schema_metadata_aspect is None.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   56m 47s ⏱️ +8s
   758 tests ±0     755 ✔️ +1  3 💤 ±0  0 ❌  - 1 
1 518 runs  ±0  1 511 ✔️ +1  7 💤 ±0  0 ❌  - 1 

Results for commit e592f34. ± Comparison against base commit e78b037.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   12m 8s ⏱️ +27s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit e592f34. ± Comparison against base commit e78b037.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 marked this pull request as ready for review November 15, 2022 21:43
treff7es
treff7es approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit a3aec72 into datahub-project:master Nov 16, 2022
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): handle missing schema in transformer (datahub-project#6445)
9a2e0c2
@hsheth2 hsheth2 deleted the schema-metadata-bug branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @treff7es