Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(home-page): remove redundant getAuthenticatedUser query #6464

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(home-page): remove redundant getAuthenticatedUser query #6464

merged 1 commit into from
Nov 17, 2022

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Nov 17, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

jjoyce0510
jjoyce0510 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 17, 2022
@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 45s ⏱️ -18s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit d75caee. ± Comparison against base commit 1fe0f01.

@aditya-radhakrishnan aditya-radhakrishnan merged commit 2a791d4 into datahub-project:master Nov 17, 2022
@aditya-radhakrishnan aditya-radhakrishnan deleted the ar--11-16-redundant-me-query branch November 17, 2022 04:22
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@aditya-radhakrishnan @cccs-Dustin
fix(home-page): remove redundant getAuthenticatedUser query (datahub-…
50d5623 
…project#6464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aditya-radhakrishnan @jjoyce0510