Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/dbt): disable incremental lineage by default #6467

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(ingest/dbt): disable incremental lineage by default #6467

merged 1 commit into from
Nov 17, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 17, 2022

Temporary fix due to an issue in GMS. Can be reverted once that is resolved.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(ingest/dbt): disable incremental lineage by default
c5c5f94 
Temporary fix due to an issue in GMS. Can be reverted once that is
resolved.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 17, 2022
shirshanka
shirshanka approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   55m 10s ⏱️
   758 tests    753 ✔️ 3 💤 2 ❌
1 518 runs  1 507 ✔️ 7 💤 4 ❌

For more details on these failures, see this check.

Results for commit c5c5f94.

@github-actions
Copy link

Unit Test Results (build & test)

622 tests  ±0   618 ✔️ ±0   15m 50s ⏱️ -15s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit c5c5f94. ± Comparison against base commit 2a791d4.

treff7es
treff7es approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit d3174e7 into datahub-project:master Nov 17, 2022
@hsheth2 hsheth2 deleted the dbt-no-incremental branch November 18, 2022 16:44
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): dbt - disable incremental lineage by default (datahub-pr…
c304b8b 
…oject#6467)
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Mar 23, 2023
@hsheth2
fix(ingest/dbt): enable incremental lineage by default
aabdd6c 
This reverts datahub-project#6467.
@hsheth2 hsheth2 mentioned this pull request Mar 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsheth2 @shirshanka @treff7es