fix(ui) Fix lineage graph rendering with duplicate nodes #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (build & test)621 tests - 1 617 ✔️ - 1 15m 49s ⏱️ -24s Results for commit 91327f7. ± Comparison against base commit d35e327. This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jjoyce0510
reviewed
Nov 17, 2022
| existingResult != null ? existingResult.getRelationships().stream() : ImmutableList.<LineageRelationship>of().stream()) | ||
| .collect(Collectors.toSet())); |
There was a problem hiding this comment.
Confused about why this was even here to begin with
There was a problem hiding this comment.
I added this earlier thinking it would help remove duplicates but dummy me it obviously does not with objects. it only worked when I manually duplicated objects that I passed into this fxn.
basically I was a bone-head and reverted this change to what it always was
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing an issue where users would drag a node on the lineage viz graph and arrows would be replicated and it looked real bad. This was happening when siblings would have the same lineage as each other, so we would render duplicate nodes causing the viz to get all wacky. This filters out duplicates when combining sibling lineage.
Also adds a safety measure on the frontend as well to ensure all edges have unique keys just in case someone wants duplicate edges on their lineage graph (saw this in OSS slack once). The arrows were bugging out because the
keys were not all unique.Checklist