refactor(ui): Adding apollo caching to manage domains page. #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,12 +64,12 @@ export const DomainsList = () => { | |||
| query, | |||
| }, | |||
| }, | |||
| fetchPolicy: 'no-cache', | |||
| fetchPolicy: 'cache-first', | |||
There was a problem hiding this comment.
interesting, nice. I know there's been bugs with using apollo cache before, but idk if that's how we were using it or if it's just difficult to work with. If it's working well for domains then we can at the very least extend this to other similar situations! (ie. the glossary)
There was a problem hiding this comment.
Seems to be working!
jjoyce0510
force-pushed
the
jj--adding-caching-domains-tab
branch
from
7ddd512
to
eac6684
Compare
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, we do our first POC of list view caching on the Domains page. No longer will we have the 3 second delay to see newly created domains. Also when navigating between pages, the Domains will be cached so another fetch is not required.
As part of this, I also added a new indexed field to Domains index that tracks the "created time" of a Domain. This allows us to consistently and correctly sort the list of domains, even when a new one is added locally.
Demo
Screen.Recording.2022-11-18.at.12.25.12.PM.mov
Checklist