fix(tableau): extra defensive error-handling #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Nov 21, 2022
| @@ -374,7 +374,9 @@ def get_connection_object_page( | |||
| if "errors" in query_data: | |||
| errors = query_data["errors"] | |||
| if all( | |||
| error.get("extensions", {}).get("severity", None) == "WARNING" | |||
| # The format of the error messages is highly unpredictable, so we have to | |||
There was a problem hiding this comment.
Nice! Our culture on connectors needs to be one of zero trust for objects we receive from foreign APIs. How can we move toward doing this ~~~everywhere~~~?
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously seeing this error:
Checklist